Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system-resources/chat): scroll to bottom and show chat on new message #2618

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

minemalox
Copy link
Contributor

Goal of this PR

Currently, when using the included system-resource chat, it does not update the scroll position of the chat window, nor does it unhide the chat window when new chat messages are received.

How is this PR achieving the goal

With the change from Vue 2 to Vue 3, watchers were changed to be shallow, so they only react when a new value is assigned but won't trigger when changing a nested value. By setting the watcher to be a deep watcher again, the chat now scrolls automatically to the last message and shows up briefly when in 'when active' mode.

This PR applies to the following area(s)

Server, system-resources: chat

Successfully tested on

Server build: 8823

Game builds: N/A

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Jul 7, 2024
@jakub-cfx
Copy link
Contributor

Was able to repro the issue, as well as confirm that the proposed fix is working. Thanks for the contribution 😊

@jakub-cfx jakub-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jul 18, 2024
@operationairstrike
Copy link

Exactly what I need

@prikolium-cfx prikolium-cfx merged commit 08156b6 into citizenfx:master Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants