feat(resources/chat): Add toggleChat for RedM and extra parameter to set chat state
#2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventually we could allow arguments to hide a chat for example when players have left with it in whenactive since it uses ResourceKvp
for example when they comeback if on a character selection the chat will be active.
`ExecuteCommand("toggleChat hidden") `
this allows to manipulate clients chat window state in other resources
for some reason it needs a wait for this suggestion to be available in the chat resource
thorium-cfx
changed the title
thorium-cfx
added
the
triage
…mmand this pr is basically same as this https://github.com/citizenfx/fivem/pull/2151/files but this one allows an extra parameter to be passed through the toggleChat command allowing resources to execute players chat states it also optimisises the look up for isRdr or not input by doing the check outside of the while loop
github-actions
bot
added
invalid
outsider31000
commented
May 19, 2024
| @@ -227,34 +227,30 @@ local CHAT_HIDE_STATES = { | |||
| local kvpEntry = GetResourceKvpString('hideState') | |||
| local chatHideState = kvpEntry and tonumber(kvpEntry) or CHAT_HIDE_STATES.SHOW_WHEN_ACTIVE | |||
| local isFirstHide = true | |||
|
|
|||
| if not isRDR then | |||
There was a problem hiding this comment.
this check is redundante since we are already checking for if RegisterKeyMapping exists, so best to remove it.
This allows to one day if it is implemented to RedM to work with no modifications needed in the future.
outsider31000
changed the title
toggleChat for RedM and extra parameter to set chat state
|
Closing this pr, as insignificant as it is, to allow RedM users to use |
|
reopening this pr upon request. |
|
#2618 this also needs to be merged, upon testing the messages dont update unless you press pageup or pagedown due to the latest commits. |
jakub-cfx
reviewed
Jul 15, 2024
fix identation to match rest of the file isFristHide variable order back to original order
|
Should be good to go. Thanks. |
jakub-cfx
added
ready-to-merge
|
8094e1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to allow the use of toggleChat command for RedM users.
It also allows an extra argument to use for chat states, for example when players have left session with state as
visiblesince it uses ResourceKvp when they re enter it shows visble, this extra parameter allows to manipulate chat state in other resourcesexample:
ExecuteCommand("toggleChat hidden")In summary:
if RegisterKeymappingshould and is enough, and a future pr wont be needed here.