-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue 132 (Public Suffix List (PSL) Updates Too Often) #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code to set modified time to now for newly downloaded PSL file to avoid multiple downloads per day.
Update domain.py
Matthew-Grayson
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
May 14, 2023 04:45
jsf9k
added
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
version bump
This issue or pull request increments the version number
python
Pull requests that update Python code
labels
May 15, 2023
jsf9k
requested changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting one very small change.
jsf9k
approved these changes
May 15, 2023
dav3r
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I also did some testing with these changes and verified that they function as expected. |
cisagovbot
pushed a commit
that referenced
this pull request
Jul 30, 2024
⚠️ CONFLICT! Lineage pull request for: skeleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
python
Pull requests that update Python code
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Added code to set the PSL file's last modified time to reflect time of last download.
💭 Motivation and context
PSL should only be downloaded once per day. The current code attempts to enforce that by only downloading a new PSL, when the local copy is older than 24 hours:
stat.st_mtime checks the last modified date of the local PSL, however, the last modified date will often be 2-4 days ago even if the PSL was downloaded minutes before.
Resolves #132.
🧪 Testing
I ran Trustymail against an array of domains.
The first domain was tested and then the code waited for a local PSL to be created before testing the remaining domains. I logged all STDOUT to see if the "PSL Updated" message appeared more than once.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist