Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to use cisagov/trustymail #2353

Closed
Matthew-Grayson opened this issue Oct 27, 2023 · 1 comment
Closed

Update requirements.txt to use cisagov/trustymail #2353

Matthew-Grayson opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels
Backend ASM-VDB Technical Infrastructure and Database Python Pull requests that update Python code

Comments

@Matthew-Grayson
Copy link
Contributor

💡 Summary

requirements.txt points to a forked repo of trustymail (Matthew-Grayson/trustymail) due to an issue with the cisagov version downloading the public suffix list too often. The issue is fixed as of 12 September 2023.

Motivation and context

The cisagov repository is actively maintained unlike the fork, which I used as a stop gap.

@Matthew-Grayson Matthew-Grayson added Backend ASM-VDB Technical Infrastructure and Database Python Pull requests that update Python code labels Oct 27, 2023
@Matthew-Grayson Matthew-Grayson self-assigned this Oct 27, 2023
@Matthew-Grayson Matthew-Grayson linked a pull request Oct 27, 2023 that will close this issue
12 tasks
@Matthew-Grayson
Copy link
Contributor Author

There is an ongoing issue with cisagov/trustymail's psl-filename and psl-readonly arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend ASM-VDB Technical Infrastructure and Database Python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant