-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory profiling #266
Closed
Closed
Memory profiling #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR adds infrastructure to perform GPU memory profiling as described in this series of blog posts by the PyTorch folks. I have added functions to initialize, record and save GPU memory traces and a notebook that uses these functions to profile forward/backward pass on a 25A waterbox.
I also added a notebook that compares the timing and memory GPU consumption of each of the implemented potentials.
This PR also adds optimization for each of the implemented networks.
ANI architecture
Investigating the memory trace shows that the computation of the angular aev allocates the largest junk of the memory:
This is due to the creation of large intermediate tensors due to broadcasting over multiple dimensions; refactoring this saves around 100 MB of GPU memory.
Key changes
Associated Issue(s)
Pull Request Checklist