Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry picked changes from other PRs #291

Merged
merged 6 commits into from
Oct 20, 2024
Merged

cherry picked changes from other PRs #291

merged 6 commits into from
Oct 20, 2024

Conversation

wiederm
Copy link
Member

@wiederm wiederm commented Oct 20, 2024

Pull Request Summary

This PR includes only refactoring changes from PR #266 and #281 . PR #266 will need more time to finish documentation and #266 can be closed after this.

Key changes

  • Reformulate the ANI2x triplet index generation based on lessons learned from memory profiling
  • change name of loss_property to loss_components

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.94%. Comparing base (59edb03) to head (b6f957a).
Report is 7 commits behind head on main.

Additional details and impacted files

@wiederm wiederm merged commit 6b0c464 into main Oct 20, 2024
0 of 2 checks passed
@wiederm wiederm deleted the dev-cherriepick branch October 20, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants