Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VL53L1X exampleを作成 #44

Merged
merged 5 commits into from
Feb 6, 2020
Merged

VL53L1X exampleを作成 #44

merged 5 commits into from
Feb 6, 2020

Conversation

rasp753
Copy link
Contributor

@rasp753 rasp753 commented Feb 6, 2020

変更点

  • ブラウザ版example
  • Node.js版example

ブラウザ版exampleについて、計測モードをとりあえずshort固定にしているが、後々ラジオボタンで選べるようにする。

@rasp753 rasp753 requested a review from kou029w February 6, 2020 07:51
@rasp753 rasp753 added the enhancement New feature or request label Feb 6, 2020
@rasp753 rasp753 requested a review from kou029w February 6, 2020 08:29
kou029w
kou029w approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@kou029w kou029w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほか変数名を直すのは後回しでOKです
また別対応としましょう

@kou029w kou029w merged commit d2bb1a4 into master Feb 6, 2020
@kou029w kou029w deleted the vl53l1x branch February 6, 2020 08:33
@kou029w kou029w mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou029w kou029w kou029w approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasp753 @kou029w