Only switch to absl::string_view implementation on Windows. #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On gcc and clang-based systems, std::string_view has the iterator behave as expected by a lot of Verible code, being a const char*. On windows c++ lib, the iterator is its own object, which does not decay to const char*, so in that case we need to use the absl:: implementation which behaves like that. We used to always change to the absl type, but in reality, we only need to do that on Windows; adapt the abseil patch. Longer term, we should remove the expectation of the iterator type, but that requires access to a Windows machine to locally go through a compile/fix loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gcc and clang-based systems, std::string_view has the iterator behave as expected by a lot of Verible code, being a const char*.
On windows c++ lib, the iterator is its own object, which does not decay to const char*, so in that case we need to use the absl:: implementation which behaves like that.
We used to always change to the absl type, but in reality, we only need to do that on Windows; adapt the abseil patch.
Longer term, we should remove the expectation of the iterator type, but that requires access to a Windows machine to locally go through a compile/fix loop.