linter: Add suspicious-semicolon rule #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 357 358 +1
Lines 26412 26432 +20
=======================================
+ Hits 24550 24569 +19
- Misses 1862 1863 +1 ☔ View full report in Codecov by Sentry. |
hzeller
reviewed
Dec 19, 2023
Inspired by clang-tidy's similar check. Things to note: verilog/tools/lint/testdata/forbid_consecutive_null_statement.sv has been modified so it doesn't fail under this rule too.
IEncinas10
force-pushed
the
bugprone-suspicious-semicolon
branch
from
fccb08b to
ebc9dc5
Compare
|
What do you think about enabling by default? |
hzeller
approved these changes
Dec 21, 2023
|
I think considering it by default sounds like a good idea, but I like to separate out the feature itself (default off) and then a separate pull request that only switches the default. That allows for a nicer rollout experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by clang-tidy's similar check.
Things to note:
I don't think this will flag any code that isn't wrong except the typical
which I don't think is a particular common idiom in [System]Verilog. It can be fixed with an empty
begin end. I could also make the check more specific (require that there isn't a function or task call inside the while condition (?)).Maybe this could be enabled by default?