linter: do not require 'default' case for 'unique case' #2000
Conversation
case-missing-default rule required the 'default' case for every case statement. This commit changes it so that case statements with the 'unique' qualifier are not marked as errors by this check.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2000 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 355 355
Lines 26272 26273 +1
=======================================
+ Hits 24395 24396 +1
Misses 1877 1877
☔ View full report in Codecov by Sentry. |
|
(currently on vacation, slow to respond with less internet bandwidth; will be back in a week or so for review) |
|
Thanks for the heads up. Enjoy the vacation! |
|
@hzeller This patch is waiting for ~8 months. I would be glad to see this patch in verible. |
I'm sure he'll review it when he feels like it. People are busy, things take time. Please be patient. If you need this feature, rebase this branch onto master and compile the project for yourself. |
|
Ah sorry everyone. This fell off my radar. Will see if I can make some time to review. |
There is no hurry at all, thanks for all your work :) |
Fixes #1278
Currently, case-missing-default rule requires the
defaultcase for every case statement. This PR makes an exception forunique casestatements as requested by the issue.I also changed where the diagnostics point to. Previously they pointed to the leftmost token of the kCaseItemList, but now they point to the
casekeyword.