Switch Kythe Kzip creator from absl::Hash to SHA256 #1997
Conversation
…ation as some Kythe tools assume SHA256 in the Kzips
This partially reverts commit 2cb9de1 (bad formatting change).
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
- Coverage 92.85% 92.85% -0.01%
==========================================
Files 355 357 +2
Lines 26272 26399 +127
==========================================
+ Hits 24395 24512 +117
- Misses 1877 1887 +10
☔ View full report in Codecov by Sentry. |
| hdrs = ["sha256.h"], | ||
| deps = [ | ||
| "@com_google_absl//absl/strings", | ||
| ], |
There was a problem hiding this comment.
The code looks like some sort of MIT license. Do we need to annotate this library with some different applicable license here in the cc_library ? (the default_applicable_license on the package-level points to apache)
(but I am also fine with deferring this decision a little bit until we talked to the licensing experts and fix it then)
There was a problem hiding this comment.
I wasn't sure what to do here. Forwarding the original license seemed like a reasonable thing to do.
I can check with the licensing experts.
Switch Kythe Kzip creator from absl::Hash to new SHA256 implementation as some Kythe tools assume SHA256 in the Kzips. The SHA256 implementation is based on https://www.rfc-editor.org/rfc/rfc6234.txt -- extracted only the SHA256 part, cleaned up the code and made it closer to C++ than C.