Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary public annotation for some local library. #1954

Merged

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jul 6, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (92dc626) 92.84% compared to head (0cc4fb3) 92.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1954   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         355      355           
  Lines       26249    26249           
=======================================
  Hits        24372    24372           
  Misses       1877     1877           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hzeller hzeller requested a review from glatosinski July 6, 2023 23:51
Copy link
Collaborator

@glatosinski glatosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hzeller hzeller merged commit bb48c4c into chipsalliance:master Jul 10, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants