Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DelayQueue #3520

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add DelayQueue #3520

merged 2 commits into from
Nov 7, 2023

Conversation

abejgonzalez
Copy link
Contributor

Related issue: #3512

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes
Adds two variations of queues that delay elements by a certain cycle count (either static at compile time or configurable during runtime). Re-uses some of the infrastructure used #3512. Replaces some of the work done in ucb-bar/chipyard#1645

@abejgonzalez abejgonzalez self-assigned this Nov 3, 2023
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the apply function signatures to
(in: DecoupledIO[T], ...) => DecoupledIO[T]. Basically match the Queue.apply in chisel?

@jerryz123
Copy link
Contributor

@Mergifyio backport master

Copy link
Contributor

mergify bot commented Nov 4, 2023

backport master

✅ Backports have been created

@abejgonzalez abejgonzalez changed the title Add DelayQueue variations Add DelayQueue Nov 4, 2023
src/main/scala/util/DelayQueue.scala Outdated Show resolved Hide resolved
src/main/scala/util/DelayQueue.scala Outdated Show resolved Hide resolved
@jerryz123 jerryz123 merged commit 04cbdf3 into chipsalliance:dev Nov 7, 2023
jerryz123 added a commit that referenced this pull request Nov 9, 2023
@cyyself cyyself mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants