-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DelayQueue #3520
Merged
Merged
Add DelayQueue #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
reviewed
Nov 3, 2023
jerryz123
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the apply
function signatures to
(in: DecoupledIO[T], ...) => DecoupledIO[T]
. Basically match the Queue.apply
in chisel?
@Mergifyio backport master |
✅ Backports have been created
|
jerryz123
reviewed
Nov 4, 2023
jerryz123
reviewed
Nov 4, 2023
jerryz123
requested changes
Nov 4, 2023
abejgonzalez
force-pushed
the
delay-queue
branch
from
November 7, 2023 01:38
e4d553e
to
b2b78fd
Compare
jerryz123
approved these changes
Nov 7, 2023
jerryz123
added a commit
that referenced
this pull request
Nov 9, 2023
Add DelayQueue (backport #3520)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3512
Type of change: other enhancement
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
Adds two variations of queues that delay elements by a certain cycle count (either static at compile time or configurable during runtime). Re-uses some of the infrastructure used #3512. Replaces some of the work done in ucb-bar/chipyard#1645