Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating copyright headers to match current best practices #39

Merged
merged 8 commits into from
May 26, 2020
Merged

Updating copyright headers to match current best practices #39

merged 8 commits into from
May 26, 2020

Conversation

kgugala
Copy link
Member

@kgugala kgugala commented Apr 21, 2020

fixes #38

@kgugala kgugala requested a review from mithro April 21, 2020 11:25
@kgugala kgugala force-pushed the license branch 3 times, most recently from b9873ae to da7250d Compare April 21, 2020 16:01
mithro
mithro suggested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the checklist at f4pga/ideas#47 and confirm everything there has been done, then re-request review!

@mithro mithro changed the title Add License headers Updating copyright headers to match current best practices Apr 22, 2020
@kgugala
Copy link
Member Author

kgugala commented Apr 28, 2020 •
edited
Loading

  • COPYING file renamed to LICENSE file
  • The LICENSE file should start with - Copyright 2020 The SymbiFlow Authors.
  • Add or update the AUTHORS files to have the text as shown at https://opensource.google/docs/releasing/authors/
  • Make sure all code files have the license specifier at the top of the file as shown at https://opensource.google/docs/releasing/licenses/
  • All code files should have SPDX identifiers.
  • Add CI which checks for all this.
  • Python files should have a #!/usr/bin/env python3 as the shebang line.
  • Python files should have a # coding: utf-8 as the second line after the shebang.
opensource.google
opensource.google

@kgugala kgugala requested a review from mithro April 28, 2020 15:50
@kgugala
Copy link
Member Author

kgugala commented May 5, 2020

@mithro is there anything in this PR than need to be adressed?

kgugala added 2 commits May 26, 2020 08:24
@kgugala @mithro
Add license headers
9189dc6 
Signed-off-by: Karol Gugala <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@kgugala @mithro
Update License
e7d1782 
Signed-off-by: Karol Gugala <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro mithro force-pushed the license branch 2 times, most recently from c57c8ea to 739a6ed Compare May 26, 2020 15:30
kgugala added 3 commits May 26, 2020 08:31
@kgugala @mithro
Add AUTHORS file
5526d04 
Signed-off-by: Karol Gugala <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@kgugala @mithro
update python headers
a392498 
Signed-off-by: Karol Gugala <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@kgugala @mithro
travis: check license headers
d4a7e62 
Signed-off-by: Karol Gugala <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
mithro added 3 commits May 26, 2020 08:37
@mithro
Fix spelling mistake.
387ef20 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Fixing flake8 error.
73caf3a 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
@mithro
Fix MANIFEST.in
1202399 
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
mithro
mithro approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some extra fixes on this. Merging now.

@mithro mithro merged commit 0afbbfe into chipsalliance:master May 26, 2020
@mithro mithro deleted the license branch May 26, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license header to top of all code files
2 participants
@kgugala @mithro