[update] Updating authorization manifest README.md and Runtime README… #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhatrevi
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
swenson and
vsonims
as code owners
mhatrevi
force-pushed
the
vmhatre/update-auth-man-doc
branch
from
3614d01 to
cbcbfba
Compare
jhand2
reviewed
Dec 23, 2024
|
|
||
| The Caliptra-Endorsed Local Verifier could be required by the owner only or both the vendor and the owner. | ||
|
|
||
| The main difference between Caliptra-Endorsed Aggregated Measured Boot and Caliptra-Endorsed Local Verifier is if the SoC RoT is relying on the Measurement Manifest for SoC Secure Boot services as opposed as using it as an additional verification. |
There was a problem hiding this comment.
nit: I think this sentence is a bit confusing. Which case is which?
|
|
||
| ### Unique Measurement Manifest Signing Keys | ||
|
|
||
| In order to reduce usage of the Caliptra FW Signing keys, the measurement manifest will be signed by new key pairs: one for the owner and possibly one for the vendor. These new key pairs are endorsed once by the Caliptra FW signing keys, the signature being in the Measurement Manifest, thus allowing the measurement manifest keys to be used independently of the Caliptra FW signing keys. |
There was a problem hiding this comment.
nit
Suggested change
| In order to reduce usage of the Caliptra FW Signing keys, the measurement manifest will be signed by new key pairs: one for the owner and possibly one for the vendor. These new key pairs are endorsed once by the Caliptra FW signing keys, the signature being in the Measurement Manifest, thus allowing the measurement manifest keys to be used independently of the Caliptra FW signing keys. | |
| In order to reduce usage of the Caliptra FW Signing keys, the measurement manifest will be signed by new key pairs: one for the owner and optionally one for the vendor. These new key pairs are endorsed once by the Caliptra FW signing keys, the signature being in the Measurement Manifest, thus allowing the measurement manifest keys to be used independently of the Caliptra FW signing keys. |
|
|
||
| ### Caliptra Measurement Manifest Vendor Public Key Authenticity | ||
|
|
||
| The Measurement Manifest MUST have an endorsement by the Caliptra Vendor Public Key. In order to fulfill this requirement, the Vendor has 2 options: |
There was a problem hiding this comment.
This makes it seem like the vendor has to sign the measurement manifest. But then below it says they can choose not to endorse it.
| @@ -58,7 +58,100 @@ Caliptra Runtime Firmware will share driver code with ROM and FMC where | |||
| possible; however, it will have its own copies of all of these drivers linked into | |||
| the Runtime Firmware binary. | |||
|
|
|||
| ## Maibox commands | |||
| ## Manifest-Based Image Authorization (new in 1.2) | |||
There was a problem hiding this comment.
This section should link the to auth manifest readme so the reader can easily find more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….md files