[feat] FMC DICE changes for adding MLDSA support #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhatrevi
force-pushed
the
vmhatre/datavault-in-dccm
branch
from
e0d80da to
92c32ad
Compare
mhatrevi
force-pushed
the
vmhatre/fmc-dice-mldsa
branch
from
5f8147a to
17b45f2
Compare
mhatrevi
force-pushed
the
vmhatre/fmc-dice-mldsa
branch
from
17b45f2 to
3faf572
Compare
mhatrevi
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
swenson,
vsonims,
FerralCoder,
korran,
ajisaxena and
JohnTraverAmd
as code owners
swenson
reviewed
Dec 18, 2024
| /// | ||
| /// * `Array4x8` - Digest | ||
| pub fn sha256_digest(sha256: &mut Sha256, data: &[u8]) -> CaliptraResult<Array4x8> { | ||
| sha256.digest(data) |
There was a problem hiding this comment.
I'm not sure why we need this function, which just wraps a simple method call? (ditto for sha384)
| /// X509 API | ||
| pub enum X509 {} | ||
|
|
||
| impl X509 { |
There was a problem hiding this comment.
Since these are already in a separate mod, it feels redundant to have an empty enum to contain. We could just have these be functions in this file without the enum and impl.
That way later we don't have to have the triply redundant caliptra_x509::x509::X509::method_name().
| use caliptra_drivers::*; | ||
| use core::mem::size_of; | ||
| use core::usize; | ||
| use zerocopy::AsBytes; | ||
|
|
||
| /// X509 API | ||
| pub enum X509 {} |
There was a problem hiding this comment.
Ditto here about eliminating this empty enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.