Add support for new IntegrityRegisters field #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the cargo-afl lockfile blocked the CI for this PR too. One solution is to lock the cargo-afl version used by the CI, similar to https://github.com/chipsalliance/caliptra-dpe/pull/368/files#diff-95bb4f36f7ea53c8ed1af485b779550e22e21e4686c5f126a64eb6b074a8f99d |
The latest DICE Attestation Architecture adds support for the IntegrityRegisters field. Use this for Cumulative measurements instead of adding a fwid.
clundin25
approved these changes
Dec 20, 2024
clundin25
reviewed
Dec 20, 2024
| // integrityRegusters[0] SEQUENCE | ||
| bytes_written += self.encode_byte(Self::SEQUENCE_TAG)?; | ||
| bytes_written += self.encode_size_field(fwid_list_size)?; | ||
|
|
There was a problem hiding this comment.
Would a comment explaining the omission of register_num be useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest DICE Attestation Architecture adds support for the IntegrityRegisters field. Use this for Cumulative measurements instead of adding a fwid.