Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the same license header but for("LGPLv3 or later") and header as checkstyle project #60

Closed
romani opened this issue Jan 7, 2017 · 3 comments

Comments

@romani
Copy link
Member

romani commented Jan 7, 2017

request to allow was sent to original authors - Sonar.
https://groups.google.com/forum/#!topic/sonarqube/rQxboJy0nY0

expected header of all files should be: https://github.com/checkstyle/checkstyle/blob/master/config/java.header
Should be enforced for all files by checkstyle validation.

@rnveach
Copy link
Member

rnveach commented Feb 14, 2017

Header was applied in #73

@romani
Copy link
Member Author

romani commented Feb 14, 2017

Sonar team want to keep LGPLv3
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/sonarqube/rQxboJy0nY0/6hbFcTrPDQAJ

On 9 January 2017 at 12:57, Olivier Gaudin <[email protected]> wrote:
Hi Roman,

The LGPL v3 was chosen on purpose for the SonarQube project to offer maximum protection to the community while being business friendly. If there is a specific reason to change I am happy to consider it but otherwise I would tend to push back on this. 

Thanks

Olivier


On Sat, Jan 7, 2017 at 7:04 PM Roman Ivanov <[email protected]> wrote:
Hi Sonar team,

During checkstyle plugin transition from Sonarqube to Checkstyle organization
https://groups.google.com/forum/#!topic/sonarqube/HXXxOWS_sOs/discussion

we did not noticed that whole code is under "LGPLv3 or (at your option) any later version"
Example: https://github.com/checkstyle/sonar-checkstyle/blob/master/checkstyle-sonar-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleAuditListener.java

Please confirm that it is ok to convert this code to "LGPLv2.1 or (at your option) any later version"
Header will be: https://github.com/checkstyle/checkstyle/blob/master/config/java.header

https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility
https://www.quora.com/What-are-the-major-differences-between-GNU-LGPL-v3-and-v2-1

So change is very cosmetic, we just allow to allow to use it from earlier version (v2.1).
I am not a lawyer, so I just want to be consistent with with checkstyle's license and give more freedom for user, as they could choose any version they want from v2.1 to any later version.

Please confirm that you are ok with re-licensing.
Or let me know if there is problem with this. 

thanks,
Roman Ivanov
-- 
You received this message because you are subscribed to the Google Groups "SonarQube" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/sonarqube/0e6c83a3-ae5e-4fda-b8b5-0125f463f9f5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
-- 
Olivier GAUDIN | SonarSource
CEO & Co-Founder
+41 (0)22 510 2424
http://sonarsource.com

@romani romani changed the title use the same license("LGPLv2.1 or later") and header as checkstyle project use the same license header but for("LGPLv3 or later") and header as checkstyle project Feb 14, 2017
@rnveach
Copy link
Member

rnveach commented Feb 14, 2017

@romani anything left to do here?

@romani romani closed this as completed Feb 14, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants