Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!: update multiformats to 10.x.x #28

Merged

Conversation

achingbrain
Copy link
Contributor

update multiformats to 10.x.x

Description

Updates the multiformats dep to the new version. This module exposes the CID class as part of the public API so it's safest if this goes out as a major.

Also updates all dev deps.

BREAKING CHANGE: the CID class used as properties of the interfaces from this module now comes from v10.x.x of the multiformats module

How Has This Been Tested?

  • Unit tests in module pass

Definition of Done

Before submitting this PR, please make sure:

  • The work addresses the description and outcomes in the issue
  • I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • My code builds and tests pass without any errors or warnings
  • I have tagged the relevant reviewers
  • I have updated the READMEs of affected packages
  • I have made corresponding changes to the documentation
  • The changes have been communicated to interested parties

References:

Updates the multiformats dep to the new version. This module exposes
the `CID` class as part of the public API so it's safest if this goes
out as a major.

BREAKING CHANGE: the `CID` class used as properties of the interfaces from this module now comes from v10.x.x of the multiformats module
@achingbrain
Copy link
Contributor Author

Refs ipld/ipld#224

@oed oed requested a review from ukstv October 17, 2022 15:11
@achingbrain
Copy link
Contributor Author

@ukstv is there any chance this could get merged please? It's needed to unblock the next js-ipfs release.

@ukstv ukstv merged commit a53a9d9 into ceramicnetwork:main Oct 19, 2022
@ukstv
Copy link
Contributor

ukstv commented Oct 19, 2022

@rvagg @achingbrain Released as 3.0.0

@achingbrain achingbrain deleted the fix/update-multiformats-to-10.x.x branch October 19, 2022 18:48
@achingbrain
Copy link
Contributor Author

Amazing, thanks!

achingbrain added a commit to achingbrain/js-dag-jose that referenced this pull request Oct 20, 2022
Followon from ceramicnetwork#28 - update @ipld/dag-cbor to same multiformats version
as the rest of the module
ukstv pushed a commit that referenced this pull request Oct 20, 2022
Followon from #28 - update @ipld/dag-cbor to same multiformats version
as the rest of the module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants