Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump @ipld/dag-cbor to 8.0.0 #29

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

achingbrain
Copy link
Contributor

deps: bump @ipld/dag-cbor to 8.0.0

Description

Following on from #28 - update @ipld/dag-cbor to same multiformats version as the rest of the module

How Has This Been Tested?

  • Unit tests in module pass

Definition of Done

Before submitting this PR, please make sure:

  • The work addresses the description and outcomes in the issue
  • I have added relevant tests for new or updated functionality
  • My code follows conventions, is well commented, and easy to understand
  • My code builds and tests pass without any errors or warnings
  • I have tagged the relevant reviewers
  • I have updated the READMEs of affected packages
  • I have made corresponding changes to the documentation
  • The changes have been communicated to interested parties

References:

#28

Followon from ceramicnetwork#28 - update @ipld/dag-cbor to same multiformats version
as the rest of the module
@achingbrain
Copy link
Contributor Author

cc @ukstv sorry - one more small one

@ukstv
Copy link
Contributor

ukstv commented Oct 20, 2022

Okay, going to release a major version soon.

@ukstv ukstv merged commit ed5329b into ceramicnetwork:main Oct 20, 2022
@achingbrain achingbrain deleted the deps/update-ipld-dag-cbor branch October 20, 2022 17:12
@ukstv
Copy link
Contributor

ukstv commented Oct 20, 2022

Hmm, the only change for @ipld/dag-cbor 7 -> 8 is ESM-only publish. We publish js-dag-jose package as ESM-only already. So, from SemVer standpoint it changes nothing for dag-jose end user. I think, patch version makes more sense here.

@achingbrain
Copy link
Contributor Author

The other thing is that the CID instances in @ipld/dag-cbor 8 come from multiformats 10 which was the upgrade in #28/[email protected] so a patch to 3.0.1 would make sense as now everything is multiformats 10.

@ukstv
Copy link
Contributor

ukstv commented Oct 20, 2022

Sweet! 3.0.1 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants