Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unit tests #24

Open
phelps-sg opened this issue Jun 10, 2023 · 3 comments
Open

Missing unit tests #24

phelps-sg opened this issue Jun 10, 2023 · 3 comments

Comments

@phelps-sg
Copy link
Contributor

No description provided.

phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 10, 2023
phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 10, 2023
phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 10, 2023
phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 10, 2023
phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 18, 2023
phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 18, 2023
phelps-sg added a commit to phelps-sg/openai-scala-client that referenced this issue Jun 18, 2023
@phelps-sg
Copy link
Contributor Author

The CI pipeline was configured with a coverage threhsold of 75%, but currently the coverage is less than 5%, so have disabled the coverage threshold check in #33 until more unit tests are available.

@phelps-sg
Copy link
Contributor Author

phelps-sg commented Jun 19, 2023

@peterbanda Just noticed recent commit removing mockito. It looks like there is no mocking framework that supports Scala 3, so the unit tests will have to be rewritten with hand-implemented mock classes: https://stackoverflow.com/questions/73082318/how-do-i-mock-classes-with-scala-3-2-scalatest-3-2-and-java-18

@peterbanda
Copy link
Member

Hey @phelps-sg , I've completely overlooked your comments. My apologies. I replaced the Mockito library with "org.scalatestplus" %% "mockito-4-11" % "3.2.16.0", exactly because of the Scala 3 support. I'm not sure if it works for you. Anyway, the upcoming release will be massive with some breaking changes, so I assume some refactoring will be needed for the tests as well (besides the Mockito adjustments). Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants