Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install github action to build and test on commit #13

Merged
merged 9 commits into from
Jun 15, 2023

Conversation

phelps-sg
Copy link
Contributor

@phelps-sg phelps-sg commented Jun 9, 2023

Configured github actions for continuous integration workflow to test that the build works.

  • uses sbt-coverage to generate coverage reports (see Missing unit tests #24)
  • uses scalafix to lint code
  • uses scalafmt to ensure code is formatted consistently (helps avoid complicated merge conflicts)
  • changes from the above plugins applied to source files

I cannot easily test my end but give me a shout if it doesn't work and I will see if I can help.

@phelps-sg phelps-sg mentioned this pull request Jun 10, 2023
@peterbanda
Copy link
Member

Hey @phelps-sg ,

This looks good! However, pls. rollback all the scalafmt and scalafix reformats/refactors. Too many changes to check...
Once it's merged I will set it up and apply to the source base myself to be compatible with the project preferences (e.g. 2 spaces instead of 4 for params).

Thanx!

@phelps-sg
Copy link
Contributor Author

I have reverted the formatting and scalafixes while retaining the corresponding plugins.
Note that this will cause the automated continuous integration checks to fail, since they check the code is properly formatted and that there are no linting issues.

To see the changes recommended by the linter:

sbt 'scalafix --check'

To apply the above changes automatically:

sbt scalafix

To see which source files have formatting issues:

sbt scalafmtCheckAll

To automatically format source code:

sbt scalafmtAll

@peterbanda
Copy link
Member

OK, looks perfect! Appreciate your effort.

@peterbanda peterbanda merged commit 2348e8e into cequence-io:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants