Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial unit tests for OpenAIRetryServiceAdapter #18

Closed
wants to merge 3 commits into from
Closed

Initial unit tests for OpenAIRetryServiceAdapter #18

wants to merge 3 commits into from

Conversation

phelps-sg
Copy link
Contributor

@phelps-sg phelps-sg commented Jun 9, 2023 •
edited
Loading

  • Implemented a unit test for OpenAIRetryServiceAdapter using scalatest and Mockito (Missing unit tests #24).
  • added scalatest and mockito deps to build.sbt
  • refactored duplicated code in WSRequestHelper

@phelps-sg phelps-sg mentioned this pull request Jun 9, 2023
Closed
@phelps-sg
Copy link
Contributor Author

phelps-sg commented Jun 10, 2023 •
edited
Loading

This has been superseded by #19 but will leave it open in case the other PR is not accepted.

@peterbanda
Copy link
Member

PR #19 merged

@peterbanda peterbanda closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phelps-sg @peterbanda