-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientProfile reconcile #48
Conversation
79ebd6d
to
7c8203c
Compare
bae9a1e
to
935e0e5
Compare
@nb-ohad can you please resolve merge conflicts? |
can below be included in this PR? diff --git a/config/rbac/kustomization.yaml b/config/rbac/kustomization.yaml
index c26ae59..3d0a21b 100644
--- a/config/rbac/kustomization.yaml
+++ b/config/rbac/kustomization.yaml
@@ -28,3 +28,21 @@ resources:
- operatorconfig_viewer_role.yaml
- driver_editor_role.yaml
- driver_viewer_role.yaml
+- csi_cephfs_ctrlplugin_clusterrole.yaml
+- csi_cephfs_ctrlplugin_clusterrole_binding.yaml
+- csi_cephfs_ctrlplugin_role.yaml
+- csi_cephfs_ctrlplugin_role_binding.yaml
+- csi_cephfs_ctrlplugin_service_account.yaml
+- csi_cephfs_nodeplugin_clusterrole.yaml
+- csi_cephfs_nodeplugin_clusterrole_binding.yaml
+- csi_cephfs_nodeplugin_service_account.yaml
+- csi_rbd_ctrlplugin_clusterrole.yaml
+- csi_rbd_ctrlplugin_clusterrole_binding.yaml
+- csi_rbd_ctrlplugin_role.yaml
+- csi_rbd_ctrlplugin_role_binding.yaml
+- csi_rbd_ctrlplugin_service_account.yaml
+- csi_rbd_nodeplugin_clusterrole.yaml
+- csi_rbd_nodeplugin_clusterrole_binding.yaml
+- csi_rbd_nodeplugin_role.yaml
+- csi_rbd_nodeplugin_role_binding.yaml
+- csi_rbd_nodeplugin_service_account.yaml |
935e0e5
to
41831b1
Compare
f69ca0d
to
ab934ce
Compare
@Madhu-1 I am adding the hold label on this one to make sure that #65 is merged first. That PR contains a small fix for map-to-string serialization needed in the code supporting Kernal and Fuse mount options. I cannot just rebase this PR on top of the fix PR because this PR is already rebased on top of the API changes which is not yet merged |
@leelavg is this request still relevant? Aren't these changes already in main? |
|
This request is out of scope of this PR. If you have the solution please provide a PR. If not please open a gitissue to track |
ab934ce
to
1c02494
Compare
@Madhu-1 |
9aa1ac4
to
8948145
Compare
8948145
to
1771e9c
Compare
…scheme Signed-off-by: nb-ohad <[email protected]>
… related ceph connection Signed-off-by: nb-ohad <[email protected]>
…ientProfile resource Signed-off-by: nb-ohad <[email protected]>
Signed-off-by: nb-ohad <[email protected]>
1771e9c
to
85dda60
Compare
Syncing latest changes from main for cephcsi-operator
Describe what this PR does
Initial implications for
clientprofiles.csi.ceph.io
controllerIs there anything that requires special attention
Controller name might need to change as of pending discussion onconfig.csi.ceph.io
name change