controllers: fix issues found in recent testing #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Below is the testing result when I rebased this PR on #48. I raised #79, #80, #81 to further refine the operations which I couldn't capture in this PR. PVC provisioning, snapshot, restore, clone. |
nb-ohad
requested changes
Aug 2, 2024
Madhu-1
reviewed
Aug 2, 2024
1. While setting SELinuxMount on CSIDriver we need to check for existence
of value set in Nodeplugin before using it or else CSIDriver will
reconile infinitely due to a spurious diff
```
(dlv) p desiredCsiDriver.Spec
k8s.io/api/storage/v1.CSIDriverSpec {
AttachRequired: *true,
PodInfoOnMount: *false,
VolumeLifecycleModes: []k8s.io/api/storage/v1.VolumeLifecycleMode len: 1, cap: 1, [
"Persistent",
],
StorageCapacity: *false,
FSGroupPolicy: *"File",
TokenRequests: []k8s.io/api/storage/v1.TokenRequest len: 0, cap: 0, nil,
RequiresRepublish: *false,
SELinuxMount: *bool nil,} <=====>
(dlv) p existingCsiDriver.Spec
k8s.io/api/storage/v1.CSIDriverSpec {
AttachRequired: *true,
PodInfoOnMount: *false,
VolumeLifecycleModes: []k8s.io/api/storage/v1.VolumeLifecycleMode len: 1, cap: 1, [
"Persistent",
],
StorageCapacity: *false,
FSGroupPolicy: *"File",
TokenRequests: []k8s.io/api/storage/v1.TokenRequest len: 0, cap: 0, nil,
RequiresRepublish: *false,
SELinuxMount: *false,} <=====>
```
2. We need to mount csi configmap in Nodeplugin as well
3. Topology feature gate should be `false` by default
4. Fix typo in CSI plugin roles
Signed-off-by: Leela Venkaiah G <[email protected]>
nb-ohad
requested changes
Aug 2, 2024
nb-ohad
approved these changes
Aug 2, 2024
Madhu-1
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
falseby default