Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV-5681: Remove analysis push and pull #181

Merged
merged 3 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions DOCUMENTATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -420,29 +420,6 @@ only the potential assignment values for connections with the appName 'Celonis'
content-cli list assignments -p <your-chosen-profile> --variableType CONNECTION --params appName=Celonis
```

### Asset options for Analysis

For migration use cases, when pulling analysis from Process Analytics
you can use the --asset option to pull the content in a generic format
that Studio accepts. As an example command for pulling an analysis with
the  --asset option would be: 

```
// Pull analysis as an asset
content-cli pull analysis -p my-profile-name --id 73d39112-73ae-4bbe-8051-3c0f14e065ec --asset
```

After you have pulled your workflows/analysis with the --asset option,
it's time to push them inside Studio. You can do accomplish this using
the same command as with pushing other assets to Studio:

```
// Push analysis to Studio
content-cli push asset -p my-profile-name -f asset_73d39112-73ae-4bbe-8051-3c0f14e065ec.yaml --package my-package-key
```

| Note: Pushing analysis from Process Analytics to Studio will only work if you have used the ***--asset*** option when pulling. |

### Pull and Push Analysis Bookmarks in Studio

Enable users to pull and push bookmarks using content-cli. For pulling analysis bookmarks
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@celonis/content-cli",
"version": "0.11.1",
"version": "0.12.0",
"description": "CLI Tool to help manage content in Celonis EMS",
"main": "content-cli.js",
"bin": {
Expand Down
18 changes: 0 additions & 18 deletions src/commands/analysis.command.ts

This file was deleted.

17 changes: 0 additions & 17 deletions src/content-cli-pull.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { AnalysisCommand } from "./commands/analysis.command";
import { SkillCommand } from "./commands/skill.command";
import { DataPoolCommand } from "./commands/data-pool.command";
import { AssetCommand } from "./commands/asset.command";
Expand All @@ -9,21 +8,6 @@ import commander = require("commander");
type CommanderStatic = commander.CommanderStatic;

class Pull {
public static analysis(program: CommanderStatic): CommanderStatic {
program
.command("analysis")
.description("Command to pull an analysis")
.option("-p, --profile <profile>", "Profile which you want to use to pull the analysis")
.requiredOption("--id <id>", "Id of the analysis you want to pull")
.option("--asset", "Pull workflow as an asset")
.action(async cmd => {
await new AnalysisCommand().pullAnalysis(cmd.profile, cmd.id, !!cmd.asset);
process.exit();
});

return program;
}

public static analysisBookmarks(program: CommanderStatic): CommanderStatic {
program
.command("bookmarks")
Expand Down Expand Up @@ -100,7 +84,6 @@ class Pull {
}
}

Pull.analysis(commander);
Pull.analysisBookmarks(commander);
Pull.skill(commander);
Pull.dataPool(commander);
Expand Down
16 changes: 0 additions & 16 deletions src/content-cli-push.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as commander from "commander";
import * as fs from "fs";
import * as path from "path";

import { AnalysisCommand } from "./commands/analysis.command";
import { SkillCommand } from "./commands/skill.command";
import { WidgetCommand } from "./commands/widget.command";
import { DataPoolCommand } from "./commands/data-pool.command";
Expand All @@ -16,20 +15,6 @@ import { GracefulError, logger } from "./util/logger";
type CommanderStatic = commander.CommanderStatic;

class Push {
public static analysis(program: CommanderStatic): CommanderStatic {
program
.command("analysis")
.description("Command to push an analysis to a workspace")
.option("-p, --profile <profile>", "Profile which you want to use to push the analysis")
.requiredOption("--workspaceId <workspaceId>", "Id of the workspace to which you want to push the analysis")
.requiredOption("-f, --file <file>", "The file you want to push")
.action(async cmd => {
await new AnalysisCommand().pushAnalysis(cmd.profile, cmd.workspaceId, cmd.file);
process.exit();
});

return program;
}

public static analysisBookmarks(program: CommanderStatic): CommanderStatic {
program
Expand Down Expand Up @@ -220,7 +205,6 @@ class Push {
}
}

Push.analysis(commander);
Push.analysisBookmarks(commander);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about bookmarks?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a feature for Studio Analysis, so it should still be working.

Push.ctp(commander);
Push.skill(commander);
Expand Down
25 changes: 0 additions & 25 deletions src/content/factory/analysis-manager.factory.ts

This file was deleted.

81 changes: 0 additions & 81 deletions src/content/manager/analysis.manager.ts

This file was deleted.

Loading