Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV-5681: Remove analysis push and pull #181

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

abdibayev
Copy link
Contributor

@abdibayev abdibayev commented Apr 16, 2024

Description

Since we are decommissioning the process-mining service
APIs will be no longer available, removed analysis push and pull from process-mining API

link to epic: DV-5591

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@abdibayev abdibayev requested review from GencBlakqoriP9 and a team as code owners April 16, 2024 15:40
@abdibayev abdibayev marked this pull request as draft April 16, 2024 15:40
@abdibayev abdibayev force-pushed the DV-5681-remove-process-mining-usage branch from a3a76e9 to 7bccb46 Compare April 16, 2024 15:43
@KhushalGupta KhushalGupta marked this pull request as ready for review November 26, 2024 13:28
KhushalGupta
KhushalGupta previously approved these changes Jan 14, 2025
@KhushalGupta
Copy link
Contributor

Could you please review this PR ? @promeris

@@ -233,7 +218,6 @@ class Push {
}
}

Push.analysis(commander);
Push.analysisBookmarks(commander);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about bookmarks?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a feature for Studio Analysis, so it should still be working.

Copy link
Collaborator

@promeris promeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump major version in package.json

@KhushalGupta KhushalGupta force-pushed the DV-5681-remove-process-mining-usage branch from eab8730 to 4e1e0c8 Compare January 17, 2025 10:40
KhushalGupta
KhushalGupta previously approved these changes Jan 17, 2025
promeris
promeris previously approved these changes Jan 17, 2025
@KhushalGupta KhushalGupta dismissed stale reviews from promeris and themself via c3ddd0e January 20, 2025 13:50
@KhushalGupta KhushalGupta requested a review from promeris January 20, 2025 13:50
@KhushalGupta
Copy link
Contributor

@promeris can you do one more review, just updated DOCUMENTATION.md ?

@KhushalGupta KhushalGupta merged commit 0a1bb44 into master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants