-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code generator: use different arrays for constants, computed constants, and algebraic variables #1247
base: main
Are you sure you want to change the base?
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd05860 - Browse repository at this point
Copy the full SHA fd05860View commit details
Commits on Aug 7, 2024
-
Code generator: use different arrays for constants, computed constant…
…s, and algebraic variables.
Configuration menu - View commit details
-
Copy full SHA for 0207ff9 - Browse repository at this point
Copy the full SHA 0207ff9View commit details -
Generator: use different arrays for constants, computed constants, an…
…d algebraic variables for initialiseVariables().
Configuration menu - View commit details
-
Copy full SHA for 329b01f - Browse repository at this point
Copy the full SHA 329b01fView commit details -
Generator: use different arrays for constants, computed constants, an…
…d algebraic variables for computeRates().
Configuration menu - View commit details
-
Copy full SHA for 56a8658 - Browse repository at this point
Copy the full SHA 56a8658View commit details -
Generator: use different arrays for constants, computed constants, an…
…d algebraic variables for computeVariables().
Configuration menu - View commit details
-
Copy full SHA for 94515cc - Browse repository at this point
Copy the full SHA 94515ccView commit details -
Generator: use different arrays for constants, computed constants, an…
…d algebraic variables for computeComputedConstants().
Configuration menu - View commit details
-
Copy full SHA for 8488c49 - Browse repository at this point
Copy the full SHA 8488c49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5287d5b - Browse repository at this point
Copy the full SHA 5287d5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c104e - Browse repository at this point
Copy the full SHA 82c104eView commit details
Commits on Aug 8, 2024
-
Tests: automatically generate the expected file contents.
To do it manually is very time consuming while here it gets done automatically. From there, we can quickly confirm, using git, whether the new expected file contents is correct.
Configuration menu - View commit details
-
Copy full SHA for 0f8fbf3 - Browse repository at this point
Copy the full SHA 0f8fbf3View commit details -
Generator profile: added setters/getters for constants, computed cons…
…tants, and algebraic arrays.
Configuration menu - View commit details
-
Copy full SHA for c2504d7 - Browse repository at this point
Copy the full SHA c2504d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01bfdec - Browse repository at this point
Copy the full SHA 01bfdecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09fcc1f - Browse repository at this point
Copy the full SHA 09fcc1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7c7774 - Browse repository at this point
Copy the full SHA a7c7774View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef86447 - Browse repository at this point
Copy the full SHA ef86447View commit details -
Analyser: keep track of computed constants and external variables for…
… an equation. We will also need to keep track of states and constants.
Configuration menu - View commit details
-
Copy full SHA for 9d7174d - Browse repository at this point
Copy the full SHA 9d7174dView commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60b26bc - Browse repository at this point
Copy the full SHA 60b26bcView commit details -
AnalyserModel: keep track of the constants, computed constants, and e…
…xternal variables.
Configuration menu - View commit details
-
Copy full SHA for 05aa338 - Browse repository at this point
Copy the full SHA 05aa338View commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c0d8a1 - Browse repository at this point
Copy the full SHA 7c0d8a1View commit details
Commits on Aug 14, 2024
-
Generator: generate the CONSTANT_INFO, COMPUTED_CONSTANT_INFO, ALGEBR…
…AIC_INFO, and EXTERNAL_INFO arrays rather than just the VARIABLE_INFO array.
Configuration menu - View commit details
-
Copy full SHA for 9f8bf25 - Browse repository at this point
Copy the full SHA 9f8bf25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bc05e8 - Browse repository at this point
Copy the full SHA 4bc05e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 330f6d6 - Browse repository at this point
Copy the full SHA 330f6d6View commit details
Commits on Aug 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aaaeed3 - Browse repository at this point
Copy the full SHA aaaeed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46e4e93 - Browse repository at this point
Copy the full SHA 46e4e93View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa807fb - Browse repository at this point
Copy the full SHA fa807fbView commit details -
Generator: initialise things in initialiseVariables() in the order of…
… its parameters.
Configuration menu - View commit details
-
Copy full SHA for 71ae73b - Browse repository at this point
Copy the full SHA 71ae73bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1b7536 - Browse repository at this point
Copy the full SHA b1b7536View commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a46dbca - Browse repository at this point
Copy the full SHA a46dbcaView commit details -
Generator: don't initialise our external variables in initialiseVaria…
…bles(). There was never a need to initialise them there in the first place. In fact, an external variable is effectively an algebraic variable which is computed by an end user. So, it needs to be computed in computeRates() (if available) and in computeVariables(). Also fixed an issue with initialiseVariables() not always including the VOI.
Configuration menu - View commit details
-
Copy full SHA for 0a05ef9 - Browse repository at this point
Copy the full SHA 0a05ef9View commit details -
Analyser: a variable using an NLA should always be an algebraic varia…
…ble. Even if the NLA equation only uses constant variables and constant values.
Configuration menu - View commit details
-
Copy full SHA for b514746 - Browse repository at this point
Copy the full SHA b514746View commit details -
Analyser: some minor cleaning up.
Constants are indexed using makeConstant().
Configuration menu - View commit details
-
Copy full SHA for 153b4b5 - Browse repository at this point
Copy the full SHA 153b4b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19126a8 - Browse repository at this point
Copy the full SHA 19126a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 841c676 - Browse repository at this point
Copy the full SHA 841c676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8afeb5c - Browse repository at this point
Copy the full SHA 8afeb5cView commit details
Commits on Aug 17, 2024
-
Generator: make sure that constants are initialised when they are nee…
…ded to initialise a state.
Configuration menu - View commit details
-
Copy full SHA for 40d3fb4 - Browse repository at this point
Copy the full SHA 40d3fb4View commit details
Commits on Aug 19, 2024
-
Generator: renamed the "external" array to "externals".
Oversight on my part!
Configuration menu - View commit details
-
Copy full SHA for b32d169 - Browse repository at this point
Copy the full SHA b32d169View commit details -
Generator: "initialise" computed constants in initialiseVariables().
This effectively reverts commit b1b7536. Indeed, some computed constants are initialised using an equation (e.g., x = 3 rather than x with an initial value of 3). So, there is no need to compute those computed constants many times (using computeComputedConstants()). Instead, it's much better to compute them in initialiseVariables(). Not to mention that we might have "computedConstants[1] = 1.0;" and then "computedConstants[0] = computedConstants[1];" so if we were to compute both of them in computeComputedConstants(), we would need to compute "computedConstants[1] = 1.0;" before computing "computedConstants[0] = computedConstants[1];", which would make things slightly more complicated to generate.
Configuration menu - View commit details
-
Copy full SHA for 8cba9cd - Browse repository at this point
Copy the full SHA 8cba9cdView commit details -
Generator: initialise things in initialiseVariables() in the order of…
… its parameters.
Configuration menu - View commit details
-
Copy full SHA for 65e1d18 - Browse repository at this point
Copy the full SHA 65e1d18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 327225a - Browse repository at this point
Copy the full SHA 327225aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1020eb - Browse repository at this point
Copy the full SHA d1020ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3bbce3 - Browse repository at this point
Copy the full SHA f3bbce3View commit details -
Generator: make sure that constants are initialised when they are nee…
…ded to initialise a state.
Configuration menu - View commit details
-
Copy full SHA for 1f09630 - Browse repository at this point
Copy the full SHA 1f09630View commit details -
GeneratorProfile: use the constants, computed constants, and algebrai…
…c arrays rather than the variables array with findRoot() & Co.
Configuration menu - View commit details
-
Copy full SHA for b54f688 - Browse repository at this point
Copy the full SHA b54f688View commit details -
GeneratorProfile: use the constants, computed constants, and algebrai…
…c arrays rather than the variables array to compute external variables.
Configuration menu - View commit details
-
Copy full SHA for d165208 - Browse repository at this point
Copy the full SHA d165208View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 183d531 - Browse repository at this point
Copy the full SHA 183d531View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 54e6673 - Browse repository at this point
Copy the full SHA 54e6673View commit details -
GeneratorProfile: use the externals array to retrieve the value of ex…
…ternal variables.
Configuration menu - View commit details
-
Copy full SHA for 62dc092 - Browse repository at this point
Copy the full SHA 62dc092View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bf1afc - Browse repository at this point
Copy the full SHA 4bf1afcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68ad0fc - Browse repository at this point
Copy the full SHA 68ad0fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff5a1a2 - Browse repository at this point
Copy the full SHA ff5a1a2View commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c83f5c7 - Browse repository at this point
Copy the full SHA c83f5c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26ba852 - Browse repository at this point
Copy the full SHA 26ba852View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 68c9895 - Browse repository at this point
Copy the full SHA 68c9895View commit details -
Tests: added a test to generate some code for the DAE version of the …
…HH52 model with various external variables.
Configuration menu - View commit details
-
Copy full SHA for f0957e0 - Browse repository at this point
Copy the full SHA f0957e0View commit details
Commits on Sep 6, 2024
-
Tests: changed the external variable in algebraicEqnWithOneNonIsolate…
…dUnknownWithExternalVariable. This is so that we can test an algebraic model with an external variable (in https://github.com/agarny/libCellMLGeneratedCodeTests).
Configuration menu - View commit details
-
Copy full SHA for 49b3a4f - Browse repository at this point
Copy the full SHA 49b3a4fView commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6b74014 - Browse repository at this point
Copy the full SHA 6b74014View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcbd038 - Browse repository at this point
Copy the full SHA dcbd038View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e3ce0d1 - Browse repository at this point
Copy the full SHA e3ce0d1View commit details