-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code generator: use different arrays for constants, computed constants, and algebraic variables #1247
Open
agarny
wants to merge
57
commits into
cellml:main
Choose a base branch
from
agarny:issue1243
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
force-pushed
the
issue1243
branch
5 times, most recently
from
August 7, 2024 12:03
874f4a6
to
5628b66
Compare
…s, and algebraic variables.
…d algebraic variables for initialiseVariables().
…d algebraic variables for computeRates().
…d algebraic variables for computeVariables().
…d algebraic variables for computeComputedConstants().
To do it manually is very time consuming while here it gets done automatically. From there, we can quickly confirm, using git, whether the new expected file contents is correct.
…tants, and algebraic arrays.
… an equation. We will also need to keep track of states and constants.
agarny
force-pushed
the
issue1243
branch
6 times, most recently
from
August 9, 2024 16:00
f21044c
to
3f1e632
Compare
agarny
added a commit
to agarny/libcellml
that referenced
this pull request
Aug 27, 2024
agarny
added a commit
to agarny/libcellml
that referenced
this pull request
Aug 27, 2024
agarny
added a commit
to agarny/libcellml
that referenced
this pull request
Aug 27, 2024
agarny
force-pushed
the
issue1243
branch
5 times, most recently
from
September 3, 2024 00:44
3d1dc96
to
7a9065f
Compare
agarny
force-pushed
the
issue1243
branch
3 times, most recently
from
September 3, 2024 04:16
8ee69e5
to
a6bf114
Compare
…HH52 model with various external variables.
…dUnknownWithExternalVariable. This is so that we can test an algebraic model with an external variable (in https://github.com/agarny/libCellMLGeneratedCodeTests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243.