Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli with malformed height #4107

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix: cli with malformed height #4107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions nodebuilder/blob/cmd/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ var getCmd = &cobra.Command{
Short: "Returns the blob for the given namespace by commitment at a particular height.\n" +
"Note:\n* Both namespace and commitment input parameters are expected to be in their hex representation.",
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[0], "0x") {
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[1], "0x") {
args[1] = "0x" + args[1]
}
if !strings.HasPrefix(args[2], "0x") {
args[2] = "0x" + args[2]
}
return nil
},
RunE: func(cmd *cobra.Command, args []string) error {
Expand Down Expand Up @@ -84,9 +84,6 @@ var getAllCmd = &cobra.Command{
Short: "Returns all blobs for the given namespace at a particular height.\n" +
"Note:\n* Namespace input parameter is expected to be in its hex representation.",
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[0], "0x") {
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[1], "0x") {
args[1] = "0x" + args[1]
}
Expand Down Expand Up @@ -150,7 +147,7 @@ var submitCmd = &cobra.Command{
"returns the header height in which the blob(s) was/were include + the respective commitment(s).\n" +
"User can use namespace and blobData as argument for single blob submission \n" +
"or use --input-file flag with the path to a json file for multiple blobs submission, \n" +
`where the json file contains:
`where the json file contains:

{
"Blobs": [
Expand Down Expand Up @@ -241,12 +238,12 @@ var getProofCmd = &cobra.Command{
Short: "Retrieves the blob in the given namespaces at the given height by commitment and returns its Proof.\n" +
"Note:\n* Both namespace and commitment input parameters are expected to be in their hex representation.",
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[0], "0x") {
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[1], "0x") {
args[1] = "0x" + args[1]
}
if !strings.HasPrefix(args[2], "0x") {
args[2] = "0x" + args[2]
}
return nil
},
RunE: func(cmd *cobra.Command, args []string) error {
Expand Down
Loading