fix: cli with malformed height

[jcstein]

Resolves #4106

Tested with:

celestia version
Semantic version: v0.11.0-rc9-738-g1e51c5f4
Commit: 1e51c5f45afd9487270600bc0a215e00b4d72e6b
Build Date: Tue Feb 11 16:54:41 EST 2025
System version: arm64/darwin
Golang version: go1.23.5

get:

celestia blob get 3980857 0xa2a78ada26ac2cbf1e86 0xeb01be57cb96f99b03e49c599e0d9f2fc08b389f49e4e8a4a273ef8a7ceb14b4
{
  "result": {
    "namespace": "0xa2a78ada26ac2cbf1e86",
    "data": "\u001bj\u000f\u0000d\<redacted-for-brevity>",
    "share_version": 0,
    "commitment": "0xeb01be57cb96f99b03e49c599e0d9f2fc08b389f49e4e8a4a273ef8a7ceb14b4",
    "index": 16
  }
}

get-proof:

celestia blob get-proof 3980857 0xa2a78ada26ac2cbf1e86 0xeb01be57cb96f99b03e49c599e0d9f2fc08b389f49e4e8a4a273ef8a7ceb14b4
{
  "result": [
    {
      "end": 4,
      "nodes": [
        "/////////////////////////////////////////////////////////////////////////////yIDfoP8WjVwWptbmj+FJ+xfBKIZeNj6LFr4G8cclyIp"
      ],
      "is_max_namespace_ignored": true
    },
    {
      "end": 3,
      "nodes": [
        "AAAAAAAAAAAAAAAAAAAAAAAAAL2dxfeNrJ+tg6YAAAAAAAAAAAAAAAAAAAAAAAAAvZ3F942sn62DpokMaI6jL6MSpiVOm43SdFVcQ556xUPCBNBCXFUKbw2Y",
        "/////////////////////////////////////////////////////////////////////////////wQI+478QQUJHztWXoov+ApInrMuv5lHSnSSU9Xfq6kp"
      ],
      "is_max_namespace_ignored": true
    }
  ]
}

get-all:

celestia blob get-all 3980857 0xa2a78ada26ac2cbf1e86
{
  "result": [
    {
      "namespace": "0xa2a78ada26ac2cbf1e86",
      "data": "\u001bj\u000f\u0000d\ufffd\ufffd\<redacted-for-brevity>",
      "share_version": 0,
      "commitment": "0xeb01be57cb96f99b03e49c599e0d9f2fc08b389f49e4e8a4a273ef8a7ceb14b4",
      "index": 16
    }
  ]
}

[jcstein]

For reviewers, it would be good to check there are not corresponding tests for this that need to be updated.

[cristaloleg]

SGTM

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.03%. Comparing base (2469e7a) to head (1e51c5f).
Report is 439 commits behind head on main.

Files with missing lines	Patch %	Lines
nodebuilder/blob/cmd/blob.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
+ Coverage   44.83%   45.03%   +0.19%     
==========================================
  Files         265      308      +43     
  Lines       14620    22494    +7874     
==========================================
+ Hits         6555    10130    +3575     
- Misses       7313    11281    +3968     
- Partials      752     1083     +331     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jcstein]

Are there tests that should be updated? I looked but can't figure out where the corresponding CLI tests are

[walldiss]

Thank you!

[cristaloleg]

Are there tests that should be updated?

AFAIR this part isn't covered with any test, so no (I will check this tomorrow).

[jcstein]

you're welcome and ty @cristaloleg - should we add tests?

[renaynay]

utack