Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function name in comments #3462

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: fix function name in comments #3462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8bfa47
fix function name
suiyuan1314 Jun 4, 2024
58340aa
Merge branch 'main' into fix-code-comments
suiyuan1314 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion share/eds/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ func (s *Store) put(ctx context.Context, root share.DataHash, square *rsmt2d.Ext
return nil
}

// waitForResult waits for a result from the res channel for a maximum duration specified by
// trackLateResult waits for a result from the res channel for a maximum duration specified by
// maxWait. If the result is not received within the specified duration, it logs an error
// indicating that the parent context has expired and the shard registration is stuck. If a result
// is received, it checks for any error and logs appropriate messages.
Expand Down
2 changes: 1 addition & 1 deletion share/eds/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ func Test_CachedAccessor(t *testing.T) {
require.Equal(t, firstBlock, secondBlock)
}

// Test_CachedAccessor verifies that the reader represented by a accessor obtained directly from
// Test_NotCachedAccessor verifies that the reader represented by a accessor obtained directly from
// dagstore can be read from multiple times, without exhausting the underlying reader.
func Test_NotCachedAccessor(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
Expand Down
2 changes: 1 addition & 1 deletion share/getters/cascade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (cg *CascadeGetter) GetSharesByNamespace(
return cascadeGetters(ctx, cg.getters, get)
}

// cascade implements a cascading retry algorithm for getting a value from multiple sources.
// cascadeGetters implements a cascading retry algorithm for getting a value from multiple sources.
// Cascading implies trying the sources one-by-one in the given order with the
// given interval until either:
// - One of the sources returns the value
Expand Down