Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function name in comments #3462

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

suiyuan1314
Copy link

fix the function name in comments to avoid ambiguity.

@github-actions github-actions bot added the external Issues created by non node team members label Jun 4, 2024
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.57%. Comparing base (2469e7a) to head (b8bfa47).
Report is 102 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
- Coverage   44.83%   44.57%   -0.26%     
==========================================
  Files         265      273       +8     
  Lines       14620    15346     +726     
==========================================
+ Hits         6555     6841     +286     
- Misses       7313     7713     +400     
- Partials      752      792      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss
Copy link
Member

walldiss commented Jun 4, 2024

@suiyuan1314 How did you find those? Would be great to automate it, to prevent such issue in future

@suiyuan1314
Copy link
Author

@walldiss Hi sir, i did those by reviewing the code manually.

@renaynay
Copy link
Member

@suiyuan1314 can you please rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants