-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make CI green #3114
chore: make CI green #3114
Conversation
… separating flakey tests
This reverts commit aaa5488.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
- Coverage 51.41% 51.10% -0.31%
==========================================
Files 177 177
Lines 11157 11157
==========================================
- Hits 5736 5702 -34
- Misses 4925 4953 +28
- Partials 496 502 +6 ☔ View full report in Codecov by Sentry. |
ok, there are still a few flakes from time to time, but this turns green more times than there is an intermittent flakey red, so IMO lets proceed then nab those flakes if/when they appear and keep moving forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about -short
and that you can use ||
in build flags like this. Very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀 . I assume the most common case for flakiness is the race inside cosmos-sdk(that's why a lot of test are build with no race flag)
Let's pay attention to our swamp tests after this PR is merged. In case it's a known flakiness, let's leave a comment in further PRs |
Building off @vgonkivs's work to skip tests, this attempts to get a baseline "green" ci for us. There are still a couple of tests that VERY intermittently flake in CI, but this way they will stand out WHEN they happen and we can track down vs entire thing being red always.
This does quite a few things
go test ./... -tags=blob
integration
tag to allow running all stillintegration-tests.yml
) which is now triggered fromgo-ci.yml
TestFullReconstructFromFulls
,TestFullReconstructFromLights
,TestSyncStartStopLightWithBridge
which is less than we were originally skipping in refactor(swamp/tests)skip tests #2802Unit tests
*_no_race_test.go
and adds!race
tag to some others to get to pass consistently when running unit tests with -race flagNext Steps
I think we let this run for a while, then once we see it be consistently green for a bit and isolate any more flakes that pop up, we can toggle on more branch requirements, then in fixing the above issues, we can be green. Being green is not easy.