Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(swarm): run swamp tests with t.Parallel to speed them up #2961

Closed
Wondertan opened this issue Nov 26, 2023 · 3 comments
Closed

test(swarm): run swamp tests with t.Parallel to speed them up #2961

Wondertan opened this issue Nov 26, 2023 · 3 comments
Assignees
@ramin
Labels
needs:triage

Comments

@Wondertan
Copy link
Member

We should also consider doing the same for unit tests.
@ramin
Copy link
Contributor

ramin commented Jan 22, 2024

i've found some of the flakiness of the swamp/integration tests was caused been alleviated by using build tags to allow running them separately/isolated, i fear that introducing the parallel would be a rabbit hole we don't have time/resource for at moment. We've made them run in "parallel" via different CI jobs in #3114 and i'd suggest that should be enough on this for now.

@ramin ramin closed this as completed Jan 22, 2024
@Wondertan
Copy link
Member Author

We should do this for at least unit tests imo

@ramin
Copy link
Contributor

ramin commented Jan 22, 2024

@Wondertan agree, i'll make a fresh issue so we can keep history ok skipping it for swamp

@ramin ramin mentioned this issue Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramin ramin

Labels
needs:triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramin @Wondertan