Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various things - WIP #241

Merged
merged 13 commits into from
Apr 29, 2019
Merged

Fix various things - WIP #241

merged 13 commits into from
Apr 29, 2019

Commits on Apr 25, 2019

  1. Django 1.11.17 is required to work with python 3.7+ so make sure to i… 

    …nstall that.
    Reece Pegues committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    87ea297 View commit details
    Browse the repository at this point in the history

  2. First pass at cleaning up the models some 

    Adding proper verbose_name and help_text for all fields.  Add validators to some as well.
Verified that manage.py test still passes.

This is a WIP though, it will need a migration before we're done.
    Reece Pegues committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    1270c3f View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2019

  1. Merge remote-tracking branch 'origin/master' into fix_various_things

    Reece Pegues committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    c18e9a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Fix flake8 errors

    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    4d7d08f View commit details
    Browse the repository at this point in the history

  2. Fix pydocstyle errors

    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    7dd73ab View commit details
    Browse the repository at this point in the history

  3. Add migration, fix migration history, add tests around migrations. 

    Migrations were broken if you went backward and forward again, so I fixed the history with a new migration.  I then was able to properly add my own new migration.  Lastly, I added tests to try and ensure no migration issues happened again.
    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    2dd3926 View commit details
    Browse the repository at this point in the history

  4. Make raw sql a tuple format to avoid sqlparse requirement

    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    25368c5 View commit details
    Browse the repository at this point in the history

  5. Must add absolute_import to every file for python2

    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    19ee5b2 View commit details
    Browse the repository at this point in the history

  6. Don't have to clear our django's migration history, apparently it wor… 

    …ks fine without that.
    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    4bc5fe3 View commit details
    Browse the repository at this point in the history

  7. sqlite won't let you run things like migrations inside another transa… 

    …ction (like a test)
    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    47f04c4 View commit details
    Browse the repository at this point in the history

  8. Fix django 2.2 tests

    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    8b7effb View commit details
    Browse the repository at this point in the history

  9. Setting TOXENV seems to no longer handle the django env variable, so … 

    …just let it do one test with latest django.
    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    e684369 View commit details
    Browse the repository at this point in the history

  10. Run migration backward/forward for all tests

    Reece Pegues committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    94753cf View commit details
    Browse the repository at this point in the history