Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various things - WIP #241

Merged
merged 13 commits into from
Apr 29, 2019
Merged

Fix various things - WIP #241

merged 13 commits into from
Apr 29, 2019

Conversation

liquidpele
Copy link
Contributor

@liquidpele liquidpele commented Apr 25, 2019 •
edited
Loading

Done stuff:

  1. Define django 1.11 tests to always use 1.11.17 or greater for python 3.7+ compatibility.
  2. clean up models, adding verbose_name properly and help_text, as well as some validators.
  3. Converted the squashed migration to a normal one, deleted the files it replaces as is recommended by this page https://docs.djangoproject.com/en/2.2/topics/migrations/#squashing-migrations
  4. Added auto migration for my own model changes - set flake8 to ignore the file because it's auto generated.
  5. Added tests to validate migrations to hopefully avoid future migration issues
  6. Added backward and forward migration as part of the test commands
  7. Also test django 2.2 with python 3.5, remove duplciate python 3.7 tests due to it not picking up the django env logic for some reason.

Reece Pegues added 2 commits April 24, 2019 22:17
Django 1.11.17 is required to work with python 3.7+ so make sure to i…
87ea297 
…nstall that.
First pass at cleaning up the models some
1270c3f 
Adding proper verbose_name and help_text for all fields.  Add validators to some as well.
Verified that manage.py test still passes.

This is a WIP though, it will need a migration before we're done.
@auvipy
Copy link
Member

auvipy commented Apr 25, 2019

ping me when ready for review

Reece Pegues added 5 commits April 28, 2019 10:40
Merge remote-tracking branch 'origin/master' into fix_various_things
c18e9a7
Fix flake8 errors
4d7d08f
Fix pydocstyle errors
7dd73ab
Add migration, fix migration history, add tests around migrations.
2dd3926 
Migrations were broken if you went backward and forward again, so I fixed the history with a new migration.  I then was able to properly add my own new migration.  Lastly, I added tests to try and ensure no migration issues happened again.
Make raw sql a tuple format to avoid sqlparse requirement
25368c5
@liquidpele liquidpele mentioned this pull request Apr 29, 2019
Closed
@liquidpele
Copy link
Contributor Author

@auvipy Okay I think this is about it for this PR. See the updated description for the list of changes.

@auvipy auvipy merged commit 0c2586b into master Apr 29, 2019
@auvipy auvipy deleted the fix_various_things branch April 29, 2019 16:30
@moseb
Copy link
Contributor

moseb commented May 2, 2019

Please note #217 (comment)

@auvipy auvipy added this to the 1.5.0 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@liquidpele @auvipy @moseb