Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21096] Make appfabric service backward compatible in CRD #128

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[CDAP-21096] Make appfabric service backward compatible in CRD #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/v1alpha1/cdapmaster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,14 @@ type CDAPScalableStatefulServiceSpec struct {
// AppFabricSpec defines the specification for the AppFabric service.
type AppFabricSpec struct {
CDAPScalableServiceSpec `json:",inline"`
// StorageSize is specification for the persistent volume size used by the service.
// Note: This is added for backward compatibility where Appfabric runs as CDAP stateful service.
// This field can be set to nil if appfabric is run as CDAP scalable service.
StorageSize *string `json:"storageSize,omitempty"`
// StorageClassName is the name of the StorageClass for the persistent volume used by the service.
// Note: This is added for backward compatibility where Appfabric runs as CDAP stateful service.
// This field can be set to nil if appfabric is run as CDAP scalable service.
StorageClassName *string `json:"storageClassName,omitempty"`
}

// AppFabricProcessorSpec defines the specification for the AppFabric Processor service.
Expand Down
10 changes: 10 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions config/crd/bases/cdap.cdap.io_cdapmasters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4411,6 +4411,14 @@ spec:
description: ServiceAccountName overrides the service account
for the service pods.
type: string
storageClassName:
description: StorageClassName is the name of the StorageClass
for the persistent volume used by the service.
type: string
storageSize:
description: StorageSize is specification for the persistent volume
size used by the service.
type: string
type: object
appFabricProcessor:
description: AppFabricProcessor is specification for the CDAP app-fabric
Expand Down
Loading