[CDAP-21096] Make appfabric service backward compatible in CRD #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng into processor
itsankit-google
approved these changes
Jan 21, 2025
vsethi09
deleted the
CDAP-21096_fix_appfabric_service_backward_cmpatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After splitting appfabric service into HTTP service and processor, the
AppFabricSpecwas changed fromCDAPStatefulServiceSpectoCDAPScalableServiceSpec. TheStorageSize&StorageClassNamefield were removed in the new CRD.For backward compatibility adding the these fields as optional. Appfabric service will continue to be created as a k8s deployment.
Reference PR: #123
Verification