Fix a bug setting keys directory permissions #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdalvaro
force-pushed
the
bugfix/keys_directory_permissions
branch
3 times, most recently
from
a8bd6cd to
1090910
Compare
cdalvaro
force-pushed
the
bugfix/keys_directory_permissions
branch
4 times, most recently
from
4b938e5 to
882f9a5
Compare
There is an issue related with salt-key and using a mounted directory as destination. See issue Permission denied on start #226
cdalvaro
force-pushed
the
bugfix/keys_directory_permissions
branch
from
882f9a5 to
344d99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
salt-keyand the generation keys directory.When the keys directory is mounted as a host volume and the host system is macOS,
salt-keycannot properly create the private keys.This PR addresses this issue by creating keys inside a temporary directory and then moving them into the destination directory.
This PR fixes #226