Test branch #23
Test branch #23
Conversation
…s and makes js versions of the FHIR resources.
boolean was being checked for nullity. Correcting expression names for generated resources.
- Updated packaging script to make mjs files from the ELM JSON - Fixed name of the dashboard library and references to it - Updated the dashboard output to align with API
test/ManagementHistologyResults/cases/I22HistologicHSILCin2.yml
Outdated
Show resolved
Hide resolved
|
@mickohanlon23 I've gone through and things look very good. Made some comments, but it's in your hands now. |
There was a problem hiding this comment.
I separated my review into 2 parts, based upon the two branches that were merged together. These comments are primarily geared towards @dwwinters and the dashboard refactor. I will follow up with any comments that come up from reviewing @ptran265's work with the CQL test cases.
A few of my comments address general issues I noticed while reviewing the CQL, and don't necessarily have to do with specific issues introduced in this PR, so feel free to move any comments over to the Issues on our repository if we want to address them down the road.
There was a problem hiding this comment.
I have reviewed the dashboard refactoring and @dwwinters has reviewed the additional test cases. All comments at this point have either been resolved or moved over to GitHub Issues. Thanks for making these updates @ptran265 and @dwwinters!
account for the latest version of the cql execution engine being more strict since it moved to TypeScript.
No description provided.