HelpersTask578_Docker_fails_due_to_missing_Docker_socket

[aangelo9]

Related to #578

Current Pipeline:

henv.env_to_str()
 └── henv.get_system_signature()
   └── hserver.get_docker_info()
     └── hserver.docker_needs_sudo()
       └── assert False # If Docker fails

We want to insert hserver.is_external_dev().
Approach:

Insert in hserver.get_docker_info():

def get_docker_info() -> str:
    ...
    if is_external_dev():
        docker_needs_sudo_ = None
    else:
        docker_needs_sudo_ = docker_needs_sudo()
    ...

Insert in henv.get_system_signature():

def get_system_signature(git_commit_type: str = "all") -> Tuple[str, int]:
    ...
    # Add Docker info conditionally
    if hserver.is_external_dev():
        txt_tmp = "External dev: skipping Docker check"
    else:
        txt_tmp = hserver.get_docker_info()
    ...

Implementation in hserver.get_docker_info() might be better for future use cases if its reused elsewhere. It also encapsulates safety logic in one place since it already calls is_inside_docker_.

[sonniki]

Insert in hserver.get_docker_info():

def get_docker_info() -> str:
    ...
    if is_external_dev():
        docker_needs_sudo_ = None
    else:
        docker_needs_sudo_ = docker_needs_sudo()
    ...

IMO this approach is better (with a comment added for clarity after if is_external_dev():, and with False instead of None to keep the type consistent).

Actually, maybe this can even be added as an extra condition in docker_needs_sudo() itself... @gpsaggese @samarth9008 @heanhsok WDYT?

[heanhsok]

@aangelo9 could you help add the fix mentioned here #578 (comment) as well ?

The file to change is
https://github.com/causify-ai/helpers/blob/master/devops/docker_build/etc_sudoers#L32

[heanhsok]

LGTM.

Thanks for the help with debugging @aangelo9

If all looks good, I can build and release a new version of //helpers image. WDYT? @gpsaggese @sonniki

[heanhsok]

LGTM

[heanhsok]

• @gpsaggese to review