HelpersTask629_Add_tests_for_dockerized_executable_sync_gh_issue_labels #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
sandeepthalapanane
requested review from
heanhsok,
sonniki,
gpsaggese and
samarth9008
…tests_for_dockerized_executable_sync_gh_issue_labels Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
…ecutable_sync_gh_issue_labels
gpsaggese
reviewed
May 4, 2025
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
…tests_for_dockerized_executable_sync_gh_issue_labels Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
heanhsok
requested changes
May 6, 2025
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/github/test/test_dockerized_sync_gh_issue_labels.py
Outdated
Show resolved
Hide resolved
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
…tests_for_dockerized_executable_sync_gh_issue_labels Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
heanhsok
requested changes
May 8, 2025
| parser = dshgdsgil._parse() | ||
| dshgdsgil._main(parser) | ||
|
|
||
| def _save_label(self, label_data: Dict[str, str]) -> dshgdsgil.Label: |
There was a problem hiding this comment.
Can we use the dshgdsgil.Label.save_labels directly so that we don't have to create another wrapper around it?
|
|
||
|
|
||
| def _get_label_data() -> Dict[str, str]: | ||
| return {"name": "test", "description": "test label", "color": "FF0000"} |
There was a problem hiding this comment.
Any reason why we don't use the Label object right away so there's no extra layer of conversion?
| self._save_label(label_data) | ||
| # Run. | ||
| self._run_with_args() | ||
| # Check if the mock was called. |
There was a problem hiding this comment.
Should we check if the create operation was called too?
Comment on lines
+36
to
+43
| label_data = { | ||
| "name": "bug", | ||
| "color": "f29513", | ||
| "description": "Something isn't working", | ||
| } | ||
| mock_label = umock.Mock() | ||
| for k, v in label_data.items(): | ||
| setattr(mock_label, k, v) |
There was a problem hiding this comment.
How about creating a label object and mock it?
| "in_dir_name": self.get_input_dir(), | ||
| "owner": "test-org", | ||
| "repo": "test-repo", | ||
| "token_env_var": "GITHUB_TEST_TOKEN", |
There was a problem hiding this comment.
I think the client running the tests might not have this var set
|
|
||
| @pytest.mark.skipif( | ||
| hserver.is_inside_ci() or hserver.is_dev_csfy(), | ||
| reason="Disabled because of CmampTask10710", |
There was a problem hiding this comment.
Are you able to run this test locally?
I'm okay with removing this test as well, since the cases covered here are already handled in the other files. Your call.
| return {"name": "test", "description": "test label", "color": "FF0000"} | ||
|
|
||
|
|
||
| def _make_mock_label(label_data: Dict[str, str]) -> umock.Mock: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #629
Implemented tests to check the Docker flow sequence for the Docker executable and also for the functionality class.