Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cmake min version deprecation warning #761

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

rickstaa
Copy link
Contributor

@rickstaa rickstaa commented Aug 14, 2023

Not sure if this is desirable given back-compatibility, but this pull request fixed the cmake min version < 3.5 deprecation warning:

Warnings   << catkin_pkg_make_err:cmake /home/ricks/development/work/catkin_tools_ws/logs/catkin_pkg_make_err/build.cmake.000.log                                                                          
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):                                                                                                                                    
  Compatibility with CMake < 3.5 will be removed from a future version of                                                                                                                                  
  CMake.                                                                                                                                                                                                   
                                                                                                                                                                                                           
  Update the VERSION argument <min> value or use a ...<max> suffix to tell                                                                                                                                 
  CMake that the project does not need compatibility with older versions.

@rickstaa
Copy link
Contributor Author

We can also update to version 3.10 since this is what is suggested by the migration guide.

@timonegk
Copy link
Member

Yes, let's do 3.10 then. ROS Noetic targets Cmake > 3.10 anyway.

@rickstaa rickstaa force-pushed the fix_cmake_deprecation_warning branch from a5beba4 to 6723f19 Compare August 15, 2023 18:07
@rickstaa
Copy link
Contributor Author

Yes, let's do 3.10 then. ROS Noetic targets Cmake > 3.10 anyway.

Cool. Done!

This commit fixed the cmake min version < 3.5 deprecation warning. It
updates the version to the one recommended by the [ROS noetic migration
guide](https://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning).
@timonegk timonegk force-pushed the fix_cmake_deprecation_warning branch from 6723f19 to 3c271a9 Compare August 15, 2023 22:06
@timonegk timonegk merged commit 9b3811b into catkin:main Aug 15, 2023
5 checks passed
@rickstaa rickstaa deleted the fix_cmake_deprecation_warning branch December 18, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants