Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start server-manager as an internal service #175

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

torives
Copy link
Contributor

@torives torives commented Nov 28, 2023

Closes #140

@torives torives self-assigned this Nov 28, 2023
@torives torives force-pushed the feature/internal-server-manager branch 4 times, most recently from 7082d35 to b6542c3 Compare November 28, 2023 21:53
@torives torives changed the title feat: start server-manager as internal service feat: start server-manager as an internal service Nov 28, 2023
@torives torives force-pushed the feature/internal-server-manager branch 3 times, most recently from d960bbf to 49790e4 Compare November 29, 2023 12:27
@torives torives requested a review from a team November 29, 2023 12:28
@torives torives marked this pull request as ready for review November 29, 2023 12:28
build/docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment; other than that, it looks good.

@torives torives force-pushed the feature/internal-server-manager branch from 49790e4 to fa2980c Compare November 30, 2023 12:18
@torives torives force-pushed the feature/internal-server-manager branch from fa2980c to 8a29323 Compare November 30, 2023 12:18
@torives torives requested a review from gligneul November 30, 2023 12:19
@torives torives merged commit f473064 into next Nov 30, 2023
4 checks passed
@torives torives deleted the feature/internal-server-manager branch November 30, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants