Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build machine snapshot using buildx #178

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

torives
Copy link
Contributor

@torives torives commented Nov 30, 2023

  • Merges machine.Dockerfile into Dockerfile
  • Moves machine snapshot generation from docker compose to docker buildx
  • Changes machine snapshot base image to cartesi/machine-emulator
    instead of cartesi/server-manager

Depends on #175
Closes #173

@torives torives self-assigned this Nov 30, 2023
@torives torives force-pushed the feature/machine-build-step branch from 714fb22 to 47d47df Compare November 30, 2023 18:01
@torives torives requested a review from a team November 30, 2023 18:03
@torives torives marked this pull request as ready for review November 30, 2023 18:17
@marcelstanley marcelstanley self-requested a review December 1, 2023 18:53
gligneul
gligneul previously approved these changes Dec 2, 2023
@gligneul gligneul dismissed their stale review December 4, 2023 19:54

The merge-base changed after approval.

Base automatically changed from next to main December 4, 2023 20:31
@gligneul gligneul added the #feat:tests Feature: tests label Dec 4, 2023
- Merges machine.Dockerfile into Dockerfile
- Moves machine snapshot generation from docker compose to docker buildx
- Changes machine snapshot base image to cartesi/machine-emulator
  instead of cartesi/server-manager
@torives torives force-pushed the feature/machine-build-step branch from 47d47df to 4f3bbe3 Compare December 5, 2023 12:59
@gligneul gligneul added the no changelog PRs that don't require changes in changelog label Dec 5, 2023
@torives torives merged commit 0ced325 into main Dec 5, 2023
6 of 7 checks passed
@torives torives deleted the feature/machine-build-step branch December 5, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#feat:tests Feature: tests no changelog PRs that don't require changes in changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create a build step for cartesi machine image
3 participants