feat: add go config #155
feat: add go config #155
Conversation
renan061
force-pushed
the
feature/go-config
branch
from
ae7214e to
4c8b350
Compare
renan061
force-pushed
the
feature/go-config
branch
2 times, most recently
from
efe40b7 to
1f2da11
Compare
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Added Go config. | |||
There was a problem hiding this comment.
If I remember correctly, the consensus was that we don't add modifications to the changelog if the change is not relevant/visible to our users, so I guess we'll add a single entry for the whole go binary, when it becomes ready for production. You can remove this and just add the no-changelog tag 😉
There was a problem hiding this comment.
We could also add a more relevant comment regarding the configuration part of the single container.
Something like: "Added unified configuration for the Node with a new set of environment variables".
There was a problem hiding this comment.
@gligneul now you got me confused. Should or shouldn't we add single container updates to the changelog? 🤔
There was a problem hiding this comment.
We should add the updates that are relevant for external users. The config part is relevant. We could add all of them in the end or start adding them as we go.
There was a problem hiding this comment.
If it is in the unreleased section, I see no harm in adding them now.
renan061
force-pushed
the
feature/go-config
branch
from
1f2da11 to
21d67bb
Compare
|
Please rebase on top of next. |
renan061
force-pushed
the
feature/go-config
branch
from
21d67bb to
a23ca0a
Compare
No description provided.