Add remaining services to cartesi-rollups-node
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torives
force-pushed
the
feat/add-remaining-services
branch
2 times, most recently
from
78b0ade to
38927c9
Compare
gligneul
reviewed
Nov 17, 2023
gligneul
reviewed
Nov 18, 2023
gligneul
reviewed
Nov 18, 2023
|
See #162 |
gligneul
reviewed
Nov 19, 2023
torives
force-pushed
the
feat/add-remaining-services
branch
2 times, most recently
from
49764ad to
f88bce5
Compare
gligneul
suggested changes
Nov 22, 2023
torives
force-pushed
the
feat/add-remaining-services
branch
2 times, most recently
from
0d6e011 to
69e746c
Compare
gligneul
previously approved these changes
Nov 23, 2023
gligneul
dismissed stale reviews from GMKrieger and themself
The merge-base changed after approval.
torives
force-pushed
the
feat/add-remaining-services
branch
from
69e746c to
fbc8df3
Compare
gligneul
previously approved these changes
Nov 27, 2023
Currently, there isn't a need to have multiple implementations of the Service interface. Therefore, this commits replaces it with its only implementation to keep things simple.
# Conflicts: # internal/services/service.go
We were incorrectly comparing the exit code with the SIGTERM signal. With this fixed, service.Start() won't return an error if the process was killed because its context was canceled
Uses context.Context to cancel services and sync.WaitGroup to wait for them to finish, making the code more idiomatic and easier to read
torives
force-pushed
the
feat/add-remaining-services
branch
from
fbc8df3 to
27a2245
Compare
gligneul
approved these changes
Nov 27, 2023
marcelstanley
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139