Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive ci link at start test & rename jenkins to ci #67

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Receive ci link at start test & rename jenkins to ci #67

merged 5 commits into from
Dec 1, 2023

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented Dec 1, 2023 •
edited by jira bot
Loading

Resolves RTW-149

Changes include:

  • Renaming jenkins link to ci link everywhere
  • Taking ci link at the start of test execution
  • Making test execution patch request parameters optional so that it's more flexible

andrejvelichkovski
andrejvelichkovski reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's just addess the type errors coming from mypy and we can merge.

andrejvelichkovski
andrejvelichkovski approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I really like the use of pydantic's HTTPURL annotation to help us automatically verify urls

@omar-selo omar-selo force-pushed the receive-ci-link-at-start-test branch from b5754d3 to e5b62db Compare December 1, 2023 12:25
@omar-selo omar-selo merged commit eef21c0 into main Dec 1, 2023
5 checks passed
@omar-selo omar-selo deleted the receive-ci-link-at-start-test branch December 1, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrejvelichkovski andrejvelichkovski andrejvelichkovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omar-selo @andrejvelichkovski