Fix mypy issues

backend/scripts/seed_data.py

@@ -120,7 +120,7 @@
 def seed_data(client: TestClient | requests.Session):
     for request in REQUESTS:
         client.put(
-            START_TEST_EXECUTION_URL, data=request.model_dump_json()
+            START_TEST_EXECUTION_URL, json=request.model_dump(mode="json")
         ).raise_for_status()
 
 

backend/test_observer/controllers/test_executions/models.py

@@ -18,6 +18,8 @@
 #        Omar Selo <[email protected]>
 
 
+from typing import Annotated
+
 from pydantic import BaseModel, HttpUrl, field_serializer, model_validator
 
 from test_observer.data_access.models_enums import FamilyName, TestExecutionStatus
@@ -35,7 +37,7 @@ class StartTestExecutionRequest(BaseModel):
     arch: str
     execution_stage: str
     environment: str
-    ci_link: HttpUrl
+    ci_link: Annotated[str, HttpUrl]
 
     @field_serializer("family")
     def serialize_dt(self, family: FamilyName):

backend/test_observer/controllers/test_executions/test_executions.py

@@ -105,8 +105,18 @@ def patch_test_execution(
     request: TestExecutionsPatchRequest,
     db: Session = Depends(get_db),
 ):
-    test_execution = db.query(TestExecution).filter(TestExecution.id == id).one()
-    test_execution.c3_link = request.c3_link
-    test_execution.ci_link = request.ci_link
-    test_execution.status = request.status
+    test_execution = db.get(TestExecution, id)
+
+    if test_execution is None:
+        raise HTTPException(status_code=404, detail="TestExecution not found")
+
+    if request.c3_link is not None:
+        test_execution.c3_link = str(request.c3_link)
+
+    if request.ci_link is not None:
+        test_execution.ci_link = str(request.ci_link)
+
+    if request.status is not None:
+        test_execution.status = request.status
+
     db.commit()

backend/test_observer/data_access/models.py

@@ -198,8 +198,8 @@ class TestExecution(Base):
 
     __tablename__ = "test_execution"
 
-    ci_link: Mapped[str] = mapped_column(String(200), nullable=True)
-    c3_link: Mapped[str] = mapped_column(String(200), nullable=True)
+    ci_link: Mapped[str | None] = mapped_column(String(200), nullable=True)
+    c3_link: Mapped[str | None] = mapped_column(String(200), nullable=True)
     # Relationships
     artefact_build_id: Mapped[int] = mapped_column(
         ForeignKey("artefact_build.id", ondelete="CASCADE")

backend/tests/controllers/test_executions/test_test_executions.py

@@ -154,7 +154,7 @@ def test_uses_existing_models(db_session: Session, test_client: TestClient):
 
     test_execution_id = test_client.put(
         "/v1/test-executions/start-test",
-        data=request.model_dump_json(),
+        json=request.model_dump(mode="json"),
     ).json()["id"]
 
     test_execution = (